Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

docs(samples): include example writing of label data #202

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

bws0013
Copy link
Contributor

@bws0013 bws0013 commented Aug 18, 2021

adding label example when writing a timeseries in python

Remaking this due to the commit lint failure in #200 and it being easier to just make a new PR. Closing #200.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [✔️] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [✔️ for linter, unable to run the nox tests because of issues unrelated] Ensure the tests and linter pass
  • [✔️] Code coverage does not decrease (if any source code was changed)
  • [✔️, no doc updates required ] Appropriate docs were updated (if necessary)

Fixes #200 🦕

adding label example when writing a timeseries in python
@bws0013 bws0013 requested a review from a team as a code owner August 18, 2021 15:16
@bws0013 bws0013 requested a review from parthea August 18, 2021 15:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2021
@product-auto-label product-auto-label bot added the api: monitoring Issues related to the googleapis/python-monitoring API. label Aug 18, 2021
@busunkim96 busunkim96 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@parthea parthea changed the title feat: including example writing of label data docs(samples): include example writing of label data Aug 27, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Aug 27, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit f5e8cf8 into googleapis:master Aug 27, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 27, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 30, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.5.0](https://www.github.com/googleapis/python-monitoring/compare/v2.4.2...v2.5.0) (2021-08-27)


### Features

* Added support for log-based alerts ([#204](https://www.github.com/googleapis/python-monitoring/issues/204)) ([b56a78c](https://www.github.com/googleapis/python-monitoring/commit/b56a78c50780e778f8ce1ad956e621433d1c451b))
* Added support for user-defined labels on cloud monitoring's Service object ([b56a78c](https://www.github.com/googleapis/python-monitoring/commit/b56a78c50780e778f8ce1ad956e621433d1c451b))
* Added support for user-defined labels on cloud monitoring's ServiceLevelObjective object ([b56a78c](https://www.github.com/googleapis/python-monitoring/commit/b56a78c50780e778f8ce1ad956e621433d1c451b))


### Bug Fixes

* mark required fields in QueryTimeSeriesRequest as required by the backend ([b56a78c](https://www.github.com/googleapis/python-monitoring/commit/b56a78c50780e778f8ce1ad956e621433d1c451b))


### Documentation

* **samples:** include example writing of label data ([#202](https://www.github.com/googleapis/python-monitoring/issues/202)) ([f5e8cf8](https://www.github.com/googleapis/python-monitoring/commit/f5e8cf8b51812b9e79bb5312f84e29b3f8c2c81e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: monitoring Issues related to the googleapis/python-monitoring API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve snippets.py example for adding label data
4 participants