Backwards compatibility with older style structured properties. #126
Conversation
googlebot
added
the
cla: yes
|
Note that coverage is complaining about an uncovered branch, but it looks to me that it is covered, so I'm not sure what's going on there. Still trying to figure that one out. |
| else: | ||
| value.b_val.update({subname: subvalue}) | ||
|
|
||
| continue |
There was a problem hiding this comment.
I've had trouble with coverage in continue statements before. Seems like the python optimizer just skips that and goes to the start of the loop directly, so the line is never reached. Solutions are: 1) Use "# pragma: no branch". 2) Turn off the optimizer. I have gone with 1) when I encounter this problem.
src/google/cloud/ndb/model.py
Outdated
| for name, value in ds_entity.items(): | ||
| prop = getattr(model_class, name, None) | ||
|
|
||
| # Backwards compatibility shim. NDB previously stored structured | ||
| # properties as sets of dotted name proprties. Datastore now has native |
There was a problem hiding this comment.
Typo on "proprties", but the just merged spell checker should catch this before your next push (once you rebase, of course).
There was a problem hiding this comment.
Actually, it looks like spell checker doesn't find it because comments don't make it into docs.
There was a problem hiding this comment.
Ha, I thought it was in a doc string. Duh.
When implementing structured properties the first time, I just used Datastore's native embedded entity functionality, not realizing that NDB had originally used dotted property names instead. (Probably GAE Datastore didn't have embedded entities when NDB was originally written.) The problem is that users migrating from GAE NDB can't load entities with structured properties from their existing datastore. This PR makes NDB backwards compatible with older, dotted name style structured properties so that existing repositories still work with the new NDB. Fixes googleapis#122.
|
Filed a bug for the coverage thing: |
chrisrossi
force-pushed
the
fix-legacy-structured-properties
branch
from
8f94e99
to
83869fa
Compare
|
Hi Chris! |
No problem. Thanks for the bug report! |
When implementing structured properties the first time, I just used
Datastore's native embedded entity functionality, not realizing that NDB
had originally used dotted property names instead. (Probably GAE
Datastore didn't have embedded entities when NDB was originally
written.) The problem is that users migrating from GAE NDB can't load
entities with structured properties from their existing datastore. This
PR makes NDB backwards compatible with older, dotted name style
structured properties so that existing repositories still work with the
new NDB.
Fixes #122.