fix: Improve test cleanup. #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that `dispose_of` is called immediately after storing an entity to make sure an error in the test doesn't prevent the entities from getting cleaned up.
googlebot
added
the
cla: yes
|
Looking at the transient errors from earlier this week, it shouldn't be possible for eventual consistency to have caused them. However, it is possible that the exception in the entity cleanup code is actually masking the true error, which actually does have to do with eventual consistency. This fix aims to prevent the entity cleanup code from potentially masking other errors by making sure there's not an opportunity to produce an error between when an entity is saved to Datastore and when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that
dispose_ofis called immediately after storing anentity to make sure an error in the test doesn't prevent the entities
from getting cleaned up.