fix: resurrect support for compressed text property #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
added 2 commits
February 21, 2020 14:06
cguardia
approved these changes
Feb 21, 2020
google/cloud/ndb/model.py
Outdated
| value (Union[bytes, str]): The value to be converted. | ||
|
|
||
| Returns: | ||
| Optional[str]: The converted value. If ``value`` is a a valid UTF-8 |
snarfed
added a commit
to snarfed/bridgy
that referenced
this pull request
Mar 5, 2020
...now that it's fixed. reverts a6deb95 in favor of the google-cloud-ndb fix in googleapis/python-ndb#342, released in v1.1.0. (thanks guys!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back in PR #35 (a fix for #32), I accidentally disabled support for passing
compressed=TruetoTextProperty. Because #35 involved refactoringTextPropertyso that it no longer inherited fromBlobProperty, the older version ofTextPropertyneeded to be brought back and has now becomeCompressedTextProperty, which will store text properties as UTF-8 compressed blobs, as was the case with GAE NDB. I've overridden__new__forTextPropertyso I can substituteCompressedTextPropertyforTextPropertywhencompressed=Trueis passed.Fixes #277