Skip to content

Commit

Permalink
fix: Update system_test_python_versions (#1096)
Browse files Browse the repository at this point in the history
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
mukund-ananthu and gcf-owl-bot[bot] committed Feb 22, 2024
1 parent efbaf61 commit c659ac7
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.rst
Expand Up @@ -143,12 +143,12 @@ Running System Tests
$ nox -s system

# Run a single system test
$ nox -s system-3.10 -- -k <name of test>
$ nox -s system-3.12 -- -k <name of test>


.. note::

System tests are only configured to run under Python 3.10.
System tests are only configured to run under Python 3.12.
For expediency, we do not run them in older versions of Python 3.

This alone will not run the tests. You'll need to change some local
Expand Down
2 changes: 1 addition & 1 deletion noxfile.py
Expand Up @@ -50,7 +50,7 @@
UNIT_TEST_EXTRAS: List[str] = []
UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {}

SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.10"]
SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.12"]
SYSTEM_TEST_STANDARD_DEPENDENCIES: List[str] = [
"mock",
"pytest",
Expand Down
2 changes: 1 addition & 1 deletion owlbot.py
Expand Up @@ -337,7 +337,7 @@
cov_level=100,
versions=gcp.common.detect_versions(path="./google", default_first=True),
unit_test_python_versions=["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"],
system_test_python_versions=["3.10"],
system_test_python_versions=["3.12"],
system_test_external_dependencies=["psutil","flaky"],
)
s.move(templated_files, excludes=[".coveragerc", ".github/release-please.yml", "README.rst", "docs/index.rst"])
Expand Down
4 changes: 3 additions & 1 deletion pytest.ini
Expand Up @@ -11,4 +11,6 @@ filterwarnings =
# Remove warning once https://github.com/googleapis/gapic-generator-python/issues/1938 is fixed
ignore:The return_immediately flag is deprecated and should be set to False.:DeprecationWarning
# Remove warning once https://github.com/googleapis/gapic-generator-python/issues/1939 is fixed
ignore:get_mtls_endpoint_and_cert_source is deprecated.:DeprecationWarning
ignore:get_mtls_endpoint_and_cert_source is deprecated.:DeprecationWarning
# Remove warning once https://github.com/grpc/grpc/issues/35974 is fixed
ignore:unclosed:ResourceWarning

0 comments on commit c659ac7

Please sign in to comment.