Skip to content

Commit

Permalink
ci: Refactor system tests with transport (#870)
Browse files Browse the repository at this point in the history
* ci: Refactor system tests

* add rest param

* fix param name

* remove rest
  • Loading branch information
acocuzzo committed Feb 17, 2023
1 parent 271a46d commit fbc7f9e
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions tests/system.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ def project():
yield default_project


@pytest.fixture()
def publisher():
yield pubsub_v1.PublisherClient()
@pytest.fixture(params=["grpc"])
def publisher(request):
yield pubsub_v1.PublisherClient(transport=request.param)


@pytest.fixture()
def subscriber():
yield pubsub_v1.SubscriberClient()
@pytest.fixture(params=["grpc"])
def subscriber(request):
yield pubsub_v1.SubscriberClient(transport=request.param)


@pytest.fixture
Expand Down Expand Up @@ -419,8 +419,8 @@ def test_subscriber_not_leaking_open_sockets(
# Also, since the client will get closed, we need another subscriber client
# to clean up the subscription. We also need to make sure that auxiliary
# subscriber releases the sockets, too.
subscriber = pubsub_v1.SubscriberClient()
subscriber_2 = pubsub_v1.SubscriberClient()
subscriber = pubsub_v1.SubscriberClient(transport="grpc")
subscriber_2 = pubsub_v1.SubscriberClient(transport="grpc")
cleanup.append(
(subscriber_2.delete_subscription, (), {"subscription": subscription_path})
)
Expand Down

0 comments on commit fbc7f9e

Please sign in to comment.