Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): correct type and description of timeout parameter in subscriber quickstart #1051

Merged
merged 7 commits into from Mar 5, 2024
Merged

docs(samples): correct type and description of timeout parameter in subscriber quickstart #1051

merged 7 commits into from Mar 5, 2024

Conversation

pradn
Copy link
Contributor

@pradn pradn commented Dec 13, 2023

Fixes #1017

@pradn pradn requested review from a team as code owners December 13, 2023 17:00
@pradn pradn requested a review from ohmayr December 13, 2023 17:00
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Dec 13, 2023
@pradn pradn mentioned this pull request Dec 13, 2023
Closed
3 tasks
@pradn pradn changed the title Fix type and description of timeout parameter in subscriber quickstart fix: correct type and description of timeout parameter in subscriber quickstart Dec 18, 2023
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@parthea parthea changed the title fix: correct type and description of timeout parameter in subscriber quickstart docs(samples): correct type and description of timeout parameter in subscriber quickstart Feb 7, 2024
@mukund-ananthu mukund-ananthu enabled auto-merge (squash) February 22, 2024 18:58
@mukund-ananthu mukund-ananthu added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@mukund-ananthu mukund-ananthu merged commit 141a473 into googleapis:main Mar 5, 2024
26 checks passed
@release-please release-please bot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@mukund-ananthu mukund-ananthu mukund-ananthu approved these changes

@ohmayr ohmayr Awaiting requested review from ohmayr ohmayr is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeout argument throw exception as wrong type (str v.s. float expected) (Snippet sample)
4 participants
@pradn @parthea @mukund-ananthu @hongalex