Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested fix to exception due to Timeout argument being string type in snippet sample sub.py. #1018

Closed
wants to merge 2 commits into from

Conversation

changlichuan
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [NA] Appropriate docs were updated (if necessary)

Fixes #1017 馃

Copy link

google-cla bot commented Nov 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Nov 1, 2023
@mukund-ananthu mukund-ananthu added the stale: old Pull request is old and needs attention. label Feb 2, 2024
@mukund-ananthu
Copy link
Contributor

Thanks changlichuan for your PR. Per the discussion here, we would be going ahead with #1051 to fix the same issue. Hence, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: xs Pull request size is extra small. stale: old Pull request is old and needs attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout argument throw exception as wrong type (str v.s. float expected) (Snippet sample)
3 participants