Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete docstrings for the use_legacy_flow_control parameter #300

Closed
plamut opened this issue Feb 27, 2021 · 0 comments · Fixed by #301
Closed

Incomplete docstrings for the use_legacy_flow_control parameter #300

plamut opened this issue Feb 27, 2021 · 0 comments · Fixed by #301
Assignees
@plamut
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: docs Improvement to the documentation for an API.

Comments

@plamut
Copy link
Contributor

plamut commented Feb 27, 2021

#231 added the use_legacy_flow_control parameter to subscriber client and documented it, but it did not document its type and and the default value in all places (example - missing from the parameter list). Docstrings should be updated accordingly.
@plamut plamut added the type: docs Improvement to the documentation for an API. label Feb 27, 2021
@plamut plamut self-assigned this Feb 27, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Feb 27, 2021
@plamut plamut mentioned this issue Feb 27, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add additional info on use_legacy_flow_control parameter plamut/python-pubsub
1 participant
@plamut