Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add additional info on use_legacy_flow_control parameter #301

Merged
merged 7 commits into from
Apr 13, 2021
Merged

docs: add additional info on use_legacy_flow_control parameter #301

merged 7 commits into from
Apr 13, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Feb 27, 2021

Closes #300.

This PR adds missing info on use_legacy_flow_control parameter where applicable

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the documentation Improvements or additions to documentation label Feb 27, 2021
@plamut plamut requested a review from a team as a code owner February 27, 2021 12:57
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Feb 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 27, 2021
@plamut plamut changed the title Iss 300 docs: add additional info on use_legacy_flow_control parameter Feb 27, 2021
@plamut plamut requested a review from pradn April 2, 2021 07:37
@plamut
Copy link
Contributor Author

plamut commented Apr 12, 2021

@pradn Ping, we just need one final rubber stamp, thanks!

@plamut plamut merged commit f47523e into googleapis:master Apr 13, 2021
@plamut plamut deleted the iss-300 branch April 13, 2021 08:33
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@kamalaboulhosn kamalaboulhosn Awaiting requested review from kamalaboulhosn

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

@pradn pradn Awaiting requested review from pradn

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incomplete docstrings for the use_legacy_flow_control parameter
5 participants
@plamut @pradn @kamalaboulhosn @hongalex @anguillanneuf