Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotation checks to CI #477

Closed
plamut opened this issue Aug 24, 2021 · 0 comments · Fixed by #499
Closed

Add type annotation checks to CI #477

plamut opened this issue Aug 24, 2021 · 0 comments · Fixed by #499
Assignees
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: process A process-related concern. May include testing, release, or the like.

Comments

@plamut
Copy link
Contributor

plamut commented Aug 24, 2021

We do not run static type checks on the code, but we probably should, which will allow us to safely incrementally annotate the library code, i.e. without incorrect annotation that would break users' checks.

Something similar to the pull request that we merged a few months ago in BigQuery.

(the scope of the issue can be extended to also include annotating all public methods) Will be done separately.

@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Aug 24, 2021
@plamut plamut self-assigned this Aug 24, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant