Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations to the codebase #500

Closed
plamut opened this issue Sep 17, 2021 · 0 comments · Fixed by #509
Closed

Add type annotations to the codebase #500

plamut opened this issue Sep 17, 2021 · 0 comments · Fixed by #509
Assignees
@plamut
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: docs Improvement to the documentation for an API.

Comments

@plamut
Copy link
Contributor

plamut commented Sep 17, 2021

Just as to #264 added type annotations to samples, this issue is about adding type hints to the library code itself.

Should wait until CI type checks are added in #477.
@plamut plamut added the type: docs Improvement to the documentation for an API. label Sep 17, 2021
@plamut plamut self-assigned this Sep 17, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 17, 2021
This was referenced Sep 24, 2021
Closed
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 1, 2021
@plamut
docs: add type annotations to codebase (#509)
093cabf 
Closes #500.

**PR checklist:**
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-pubsub/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
@plamut plamut mentioned this issue Nov 11, 2021
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add type annotations to codebase plamut/python-pubsub
1 participant
@plamut