Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add google-auth as a direct dependency #1076

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix: add google-auth as a direct dependency #1076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< 3.0.dev0 to match https://github.com/googleapis/python-api-core/blob/82c31184168d92a88ea570780082ab1176cfed53/setup.py#L34

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing change seems to be consistent with googleapis/python-bigquery-storage@56e8958 which also refers to https://github.com/googleapis/python-api-core/blob/82c31184168d92a88ea570780082ab1176cfed53/setup.py#L34 and the way the versions are mentioned for the other lines in the file.

Tagging @parthea to get his input on this.

Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
dependencies = [
"grpcio >= 1.51.3, < 2.0dev", # https://github.com/googleapis/python-pubsub/issues/609
# google-api-core >= 1.34.0 is allowed in order to support google-api-core 1.x
"google-auth >= 2.14.1, <3.0.0dev",
"google-api-core[grpc] >= 1.34.0, <3.0.0dev,!=2.0.*,!=2.1.*,!=2.2.*,!=2.3.*,!=2.4.*,!=2.5.*,!=2.6.*,!=2.7.*,!=2.8.*,!=2.9.*,!=2.10.*",
"proto-plus >= 1.22.0, <2.0.0dev",
"proto-plus >= 1.22.2, <2.0.0dev; python_version>='3.11'",
Expand Down
1 change: 1 addition & 0 deletions testing/constraints-3.7.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# e.g., if setup.py has "google-cloud-foo >= 1.14.0, < 2.0.0dev",
# Then this file should have google-cloud-foo==1.14.0
google-api-core==1.34.0
google-auth==2.14.1
proto-plus==1.22.0
protobuf==3.19.5
grpc-google-iam-v1==0.12.4
Expand Down