Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Catch and surface BaseException() #1108

Merged
merged 3 commits into from Mar 6, 2024
Merged

fix: Catch and surface BaseException() #1108

merged 3 commits into from Mar 6, 2024

Commits on Mar 5, 2024

  1. fix: Catch and surface BaseException() 

    Currently, the behavior of the library is to catch Exception() when encountered in the user provided callback, surface it to the calling code and shut down the client.

However, for BaseException() encountered in the user provided callback, the BaseException() is not surfaced to the calling code and the client is not shut down.

Make the behavior of the client when BaseException() is encountered consistent with the behavior of the client when Exception() is encountered.
    @mukund-ananthu
    mukund-ananthu committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d43c2e3 View commit details
    Browse the repository at this point in the history

  2. 馃 Updates from OwlBot post-processor 

    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    @gcf-owl-bot
    gcf-owl-bot[bot] committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d9429e7 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge branch 'main' into be

    @mukund-ananthu
    mukund-ananthu committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    558d4ac View commit details
    Browse the repository at this point in the history