Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix create_topic() call in README #360

Merged
merged 1 commit into from
Apr 1, 2021
Merged

docs: fix create_topic() call in README #360

merged 1 commit into from
Apr 1, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Apr 1, 2021

Fixes #349.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the samples Issues that are directly related to samples. label Apr 1, 2021
@plamut plamut requested a review from a team as a code owner April 1, 2021 09:22
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Apr 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2021
pradn
pradn approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pradn pradn merged commit f5eee4b into googleapis:master Apr 1, 2021
@plamut plamut deleted the iss-349 branch April 2, 2021 07:24
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example of using PublisherClient's create_topic method cause TypeError
2 participants
@plamut @pradn