Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scheduler errors when executor in shutdown #399

merged 1 commit into from May 18, 2021


Copy link

@plamut plamut commented Apr 27, 2021

Fixes #394 (possibly).

This PR fixes uncaught exceptions in internal scheduler that can happen when the underlying executor is already being shut down (by another thread). It might not fix the reported hanging behavior, but it's a start.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
Copy link
Contributor Author

@plamut plamut commented Apr 28, 2021

Stale CI checks.


@plamut plamut merged commit 39a83d3 into googleapis:master May 18, 2021
7 checks passed
@plamut plamut deleted the iss-394 branch May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants