Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change info logs to debug #693

Merged
merged 8 commits into from
Jun 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def heartbeat(self) -> None:
_LOGGER.debug("Sent heartbeat.")
self._stop_event.wait(timeout=self._period)

_LOGGER.info("%s exiting.", _HEARTBEAT_WORKER_NAME)
_LOGGER.debug("%s exiting.", _HEARTBEAT_WORKER_NAME)

def start(self) -> None:
with self._operational_lock:
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/pubsub_v1/subscriber/_protocol/leaser.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def maintain_leases(self) -> None:
_LOGGER.debug("Snoozing lease management for %f seconds.", snooze)
self._stop_event.wait(timeout=snooze)

_LOGGER.info("%s exiting.", _LEASE_WORKER_NAME)
_LOGGER.debug("%s exiting.", _LEASE_WORKER_NAME)

def start(self) -> None:
with self._operational_lock:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ def heartbeat(self) -> bool:
request = gapic_types.StreamingPullRequest(
stream_ack_deadline_seconds=self.ack_deadline
)
_LOGGER.info(
_LOGGER.debug(
"Sending new ack_deadline of %d seconds.", self.ack_deadline
)
else:
Expand Down Expand Up @@ -1081,9 +1081,9 @@ def _should_recover(self, exception: BaseException) -> bool:
# If this is in the list of idempotent exceptions, then we want to
# recover.
if isinstance(exception, _RETRYABLE_STREAM_ERRORS):
_LOGGER.info("Observed recoverable stream error %s", exception)
_LOGGER.debug("Observed recoverable stream error %s", exception)
return True
_LOGGER.info("Observed non-recoverable stream error %s", exception)
_LOGGER.debug("Observed non-recoverable stream error %s", exception)
return False

def _should_terminate(self, exception: BaseException) -> bool:
Expand All @@ -1101,9 +1101,9 @@ def _should_terminate(self, exception: BaseException) -> bool:
"""
exception = _wrap_as_exception(exception)
if isinstance(exception, _TERMINATING_STREAM_ERRORS):
_LOGGER.info("Observed terminating stream error %s", exception)
_LOGGER.debug("Observed terminating stream error %s", exception)
return True
_LOGGER.info("Observed non-terminating stream error %s", exception)
_LOGGER.debug("Observed non-terminating stream error %s", exception)
return False

def _on_rpc_done(self, future: Any) -> None:
Expand All @@ -1117,7 +1117,7 @@ def _on_rpc_done(self, future: Any) -> None:
with shutting everything down. This is to prevent blocking in the
background consumer and preventing it from being ``joined()``.
"""
_LOGGER.info("RPC termination has signaled streaming pull manager shutdown.")
_LOGGER.debug("RPC termination has signaled streaming pull manager shutdown.")
error = _wrap_as_exception(future)
thread = threading.Thread(
name=_RPC_ERROR_THREAD_NAME, target=self._shutdown, kwargs={"reason": error}
Expand Down
4 changes: 2 additions & 2 deletions samples/snippets/subscriber.py
Original file line number Diff line number Diff line change
Expand Up @@ -771,14 +771,14 @@ def synchronous_pull_with_lease_management(
"ack_deadline_seconds": 15,
}
)
logger.info(f"Reset ack deadline for {msg_data}.")
logger.debug(f"Reset ack deadline for {msg_data}.")

# If the process is complete, acknowledge the message.
else:
subscriber.acknowledge(
request={"subscription": subscription_path, "ack_ids": [ack_id]}
)
logger.info(f"Acknowledged {msg_data}.")
logger.debug(f"Acknowledged {msg_data}.")
processes.pop(process)
print(
f"Received and acknowledged {len(response.received_messages)} messages from {subscription_path}."
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/pubsub_v1/subscriber/test_leaser.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def create_manager(flow_control=types.FlowControl()):


def test_maintain_leases_inactive_manager(caplog):
caplog.set_level(logging.INFO)
caplog.set_level(logging.DEBUG)
manager = create_manager()
manager.is_active = False

Expand All @@ -107,7 +107,7 @@ def test_maintain_leases_inactive_manager(caplog):


def test_maintain_leases_stopped(caplog):
caplog.set_level(logging.INFO)
caplog.set_level(logging.DEBUG)
manager = create_manager()

leaser_ = leaser.Leaser(manager)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ def test_heartbeat_inactive():


def test_heartbeat_stream_ack_deadline_seconds(caplog):
caplog.set_level(logging.INFO)
caplog.set_level(logging.DEBUG)
manager = make_manager()
manager._rpc = mock.create_autospec(bidi.BidiRpc, instance=True)
manager._rpc.is_active = True
Expand Down