Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add samples python 3.11 to required checks #950

Closed
wants to merge 0 commits into from
Closed

CI: add samples python 3.11 to required checks #950

wants to merge 0 commits into from

Conversation

liuyunnnn
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@liuyunnnn liuyunnnn requested a review from a team as a code owner July 13, 2023 19:21
@liuyunnnn liuyunnnn requested a review from a team as a code owner July 13, 2023 19:21
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Jul 13, 2023
@liuyunnnn liuyunnnn changed the title add samples python 3.11 to required checks CI: add samples python 3.11 to required checks Jul 13, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@dandhlee
Copy link
Contributor

3.11 tests aren't added yet. Please ping me directly internally if this is required!

@liuyunnnn liuyunnnn closed this Jul 13, 2023
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: u Pull request is empty.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants