Skip to content

Commit

Permalink
fix: Disable publish idempotence by default (#415)
Browse files Browse the repository at this point in the history
The python library sends batches out of order, which fails validation on the server when publish idempotence is enabled.
  • Loading branch information
tmdiep committed May 10, 2023
1 parent 3eca8cc commit 17af3c4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions google/cloud/pubsublite/cloudpubsub/publisher_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def __init__(
credentials: Optional[Credentials] = None,
transport: str = "grpc_asyncio",
client_options: Optional[ClientOptions] = None,
enable_idempotence: bool = True,
enable_idempotence: bool = False,
):
"""
Create a new PublisherClient.
Expand Down Expand Up @@ -148,7 +148,7 @@ def __init__(
credentials: Optional[Credentials] = None,
transport: str = "grpc_asyncio",
client_options: Optional[ClientOptions] = None,
enable_idempotence: bool = True,
enable_idempotence: bool = False,
):
"""
Create a new AsyncPublisherClient.
Expand Down

0 comments on commit 17af3c4

Please sign in to comment.