Unit test test_nack_calls_ack test hangs with google-cloud-pubsub==2.10.0 #311
Assignees
Labels
api: pubsublite
Issues related to the googleapis/python-pubsublite API.
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
parthea
added
type: bug
product-auto-label
bot
added
the
api: pubsublite
dpcollins-google
added a commit
that referenced
this issue
Mar 7, 2022
…om the cloud Pub/Sub Message fixes: #311
dpcollins-google
added a commit
that referenced
this issue
Mar 7, 2022
…om the cloud Pub/Sub Message fixes: #311
dpcollins-google
added a commit
that referenced
this issue
Mar 7, 2022
…om the cloud Pub/Sub Message fixes: #311
dpcollins-google
added a commit
that referenced
this issue
Mar 7, 2022
…om the cloud Pub/Sub Message fixes: #311
dpcollins-google
added a commit
that referenced
this issue
Mar 7, 2022
…om the cloud Pub/Sub Message fixes: #311
dpcollins-google
added a commit
that referenced
this issue
Mar 7, 2022
…om the cloud Pub/Sub Message (#312) * fix: ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message fixes: #311 * fix: ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message fixes: #311 * fix: ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message fixes: #311 * fix: ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message fixes: #311 * fix: ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message fixes: #311
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Mar 7, 2022
🤖 I have created a release *beep* *boop* --- ### [1.4.1](v1.4.0...v1.4.1) (2022-03-07) ### Bug Fixes * ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message ([#312](#312)) ([19da693](19da693)), closes [#311](#311) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
python-pubsublite/tests/unit/pubsublite/cloudpubsub/internal/single_partition_subscriber_test.py
Lines 250 to 252 in 1d223f4
Unit test
test_nack_calls_ack()started timing out in main aftergoogle-cloud-pubsub==2.10.0was released. See build log here and the checks in PR #310.Test
test_nack_calls_ack()no longer hangs when I change thegoogle-cloud-pubsubdependency insetup.pyfrom"google-cloud-pubsub >= 2.1.0, <3.0.0dev",to"google-cloud-pubsub >= 2.1.0, <3.0.0dev, !=2.10.0",The text was updated successfully, but these errors were encountered: