Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message #312

Merged
merged 5 commits into from
Mar 7, 2022

Conversation

dpcollins-google
Copy link
Collaborator

fixes: #311

@dpcollins-google dpcollins-google requested review from a team as code owners March 7, 2022 14:43
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Mar 7, 2022
Copy link

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change to not rely on the Message ctor. Just one comment for thought. Thanks!

@dpcollins-google dpcollins-google added the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2022
@dpcollins-google dpcollins-google merged commit 19da693 into main Mar 7, 2022
@dpcollins-google dpcollins-google deleted the dont_use_message_impl branch March 7, 2022 18:03
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 7, 2022
🤖 I have created a release *beep* *boop*
---


### [1.4.1](v1.4.0...v1.4.1) (2022-03-07)


### Bug Fixes

* ignore the implementation details of message acknowledgements from the cloud Pub/Sub Message ([#312](#312)) ([19da693](19da693)), closes [#311](#311)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/python-pubsublite API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test test_nack_calls_ack test hangs with google-cloud-pubsub==2.10.0
3 participants