Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: set up samples directory #33

Merged
merged 2 commits into from
Oct 2, 2020
Merged

samples: set up samples directory #33

merged 2 commits into from
Oct 2, 2020

Conversation

anguillanneuf
Copy link
Collaborator

@anguillanneuf anguillanneuf commented Oct 2, 2020 •
edited

Because library is not yet published to pypi, defaulted INSTALL_LIBRARY_FROM_SOURCE to True in noxfile.py:

# TODO: change the default to False when this repo is public.
INSTALL_LIBRARY_FROM_SOURCE = bool(os.environ.get("INSTALL_LIBRARY_FROM_SOURCE", True))

This makes sure that pytest is run against the editable version of the library on GitHub, i.e. against HEAD.

Created a tracking issue #35

@anguillanneuf anguillanneuf requested a review from a team as a code owner October 2, 2020 00:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2020
@anguillanneuf anguillanneuf requested a review from a team as a code owner October 2, 2020 16:52
leahecole
leahecole approved these changes Oct 2, 2020
View reviewed changes
Copy link

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be sure to make that issue to double check the noxfile before going public :)

@anguillanneuf anguillanneuf merged commit bc3318e into master Oct 2, 2020
@anguillanneuf anguillanneuf deleted the samples branch October 2, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@dpcollins-google dpcollins-google dpcollins-google approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anguillanneuf @leahecole @dpcollins-google