feat: Implement aggregator #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a generalization of order-preserving batching routines. It flushes on a given period.
…s once restart is called.
pradn
approved these changes
Aug 7, 2020
| gen: int | ||
| items: List[WorkItem[Request]] | ||
|
|
||
| def __init__(self, gen: int): |
There was a problem hiding this comment.
Perhaps a more descriptive name than "gen"?
| raise NotImplementedError() | ||
|
|
||
|
|
||
| class Aggregator(Generic[Request, Response]): |
There was a problem hiding this comment.
Class comment + general explanation of how it works.
|
Closing this. Turns out the fact that it calls through to the underlying class makes it very hard to maintain order on restarts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an abstraction over order-preserving batching routines used for publishing, subscribe flow control, and commits.
Diffbased on #5