Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't use Django fork for testing #527

Closed
wants to merge 13 commits into from

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Oct 5, 2020

Closes #485

@IlyaFaer IlyaFaer added type: process A process-related concern. May include testing, release, or the like. api: spanner Issues related to the googleapis/python-spanner-django API. labels Oct 5, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 5, 2020
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2020
@IlyaFaer
Copy link
Contributor Author

IlyaFaer commented Oct 8, 2020

@busunkim96, could you take a look and maybe advise something? I saw you dealing with similar problems.

According to the logs requests package is already installed, but somewhy the code can't import it. I've tried to add package update, and even reinstalling it, into several places, but it doesn't give any effect. Seems like something environment related to me.

Thanks in advance!

@busunkim96
Copy link
Contributor

Hi @IlyaFaer,

I would create a new virtual environment and install the test requirements there. It's possible to force an upgrade of the requests version installed in the kokoro environment, but Kokoro may be depending on the specific version installed.

python3 -m venv env
source env/bin/activate
python3 -m pip install -r requirements.txt ...

@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2020
@IlyaFaer IlyaFaer closed this Jan 20, 2021
@IlyaFaer IlyaFaer deleted the dont_use_django_fork branch January 20, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cleanup] Don't use django fork in build script
4 participants