test: use parallel workflows to run Django tests #569

IlyaFaer · 2020-12-16T08:53:39Z

No description provided.

…c/python-spanner-django into dj_tests_against_emulator

c24t

Great work splitting the emulator and non-emulator tests and getting to a green build.

Some comments and possible cleanup work, but once the pip install -e git... lines are removed I think we should be ready to merge.

.kokoro/build.sh

.github/workflows/django_tests_against_emulator0.yml

django_spanner/base.py

create_test_instance.py

django_test_suite.sh

This reverts commit e3bdc2a.

c24t · 2021-01-27T03:53:53Z

django_test_suite.sh

+if [ $SPANNER_EMULATOR_HOST != 0 ]
+then
+    pip3 install .
+    pip3 install -e 'git+https://github.com/q-logic/python-spanner-django.git@dj_tests_against_emulator#egg=django-google-spanner'


Reminder for later: remove this and DRY up .kokoro/build.sh.

This reverts commit 1d0f44c.

This reverts commit 7f114db.

This reverts commit 08fb726.

c24t

Approving at the last green build rev, thanks for the long and hard work getting these tests to pass @IlyaFaer.

Ilya Gurov and others added 30 commits November 26, 2020 12:58

test: move Django tests to emulator (#27)

a031f35

cleanup

dc8eeb0

rename checks

b9f35de

install from git

1e2f9f4

re-run

0cd1022

re-run

ca44c22

re-run

53d151f

delete compiler

c569293

re-run

6150e1c

don't change delete compiler

1d85f80

re-run

cfbcd34

revert debug changes

6e408ef

re-run

1dbc429

re-run

4a23973

900

45fd22f

re-run

9dc1c13

try splitting tests

3b5cef2

more splits

70e2e77

parallel

00f42f0

use several emulator

9dee14b

create instance in every thread

c1ac815

use 8 threads

e7a3aac

skip tests, which are using unsupported types

4c9daf2

re-run

93eb7fa

fix typo

e7e89fd

Merge branch 'master' into dj_tests_against_emulator

993ea34

Fix typos in test runner script

eaf5374

use unique instance names

1c35b27

Merge branch 'dj_tests_against_emulator' of https://github.com/q-logi…

f0c9808

…c/python-spanner-django into dj_tests_against_emulator

revert

8989939

IlyaFaer added 7 commits January 20, 2021 20:27

re-run

bfe824c

re-run

82e83d1

re-run

cf490a8

re-run

8bab785

re-run

b9ffb6e

don't re-install

929ddac

re-run

83465da

IlyaFaer marked this pull request as ready for review January 21, 2021 19:29

IlyaFaer requested a review from a team as a code owner January 21, 2021 19:29

c24t reviewed Jan 22, 2021

View reviewed changes

Try removing special case package installs

e3bdc2a

c24t reviewed Jan 22, 2021

View reviewed changes

django_test_suite.sh Show resolved Hide resolved

IlyaFaer added 5 commits January 25, 2021 10:39

Revert "Try removing special case package installs"

f1aee13

This reverts commit e3bdc2a.

use released python-spanner

c5ceb43

use released python-spanner version

e464963

don't install Django twice

6587545

fix env vars

1950c63

c24t added a commit to c24t/python-spanner-django that referenced this pull request Jan 27, 2021

Try using googleapis#569 branch

e8fe9c3

Don't set -x, do set -o pipefail

08fb726

c24t reviewed Jan 27, 2021

View reviewed changes

c24t added 5 commits January 28, 2021 01:21

s/sh/bash/

7f114db

Use bash, not sh, in GH django test workflows

1d0f44c

Revert "Use bash, not sh, in GH django test workflows"

5f94e2f

This reverts commit 1d0f44c.

Revert "s/sh/bash/"

98a4916

This reverts commit 7f114db.

Revert "Don't set -x, do set -o pipefail"

6b63bd2

This reverts commit 08fb726.

c24t approved these changes Jan 28, 2021

View reviewed changes

c24t merged commit 3cb51a6 into googleapis:master Jan 28, 2021

This was referenced Jan 29, 2021

fix: Don't reinstall package in CI #584

Closed

Fix parallel test failures #540

Closed

IlyaFaer deleted the eight_workflows branch February 1, 2021 08:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: use parallel workflows to run Django tests #569

test: use parallel workflows to run Django tests #569

IlyaFaer commented Dec 16, 2020

c24t left a comment

c24t Jan 27, 2021

c24t left a comment

test: use parallel workflows to run Django tests #569

test: use parallel workflows to run Django tests #569

Conversation

IlyaFaer commented Dec 16, 2020

c24t left a comment

Choose a reason for hiding this comment

c24t Jan 27, 2021

Choose a reason for hiding this comment

c24t left a comment

Choose a reason for hiding this comment