-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Samples section to CONTRIBUTING.rst #424
docs: add Samples section to CONTRIBUTING.rst #424
Conversation
Source-Link: googleapis/synthtool@52e4e46 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605
@parthea One note about this batched set of PRs: the prefix should be |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Unit test failures on Python 3.7, 3.8, and 3.9 are all in opentelemetry-related assertions, likely due to a recent release of $ .nox/unit-3-9/bin/pip install --upgrade opentelemetry-{instrumentation,semantic-conventions}==0.22b0 opentelemetry-{api,sdk}==1.3.0 |
@larkee , please can you review/approve https://github.com/googleapis/python-spanner/pull/366/files first? Once it's merged, I can pull in those changes into this PR to avoid conflicts with owlbot.py |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
…294929221d060634dae4a0795c1cefdbc995b2d605
Superseded by #426 |
Source-Link: googleapis/synthtool@52e4e46
Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605