test: fix result ordering errors for emulator #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkee
added
the
api: spanner
googlebot
added
the
cla: yes
|
@larkee The kokoro test fails. Please fix it so that I can review this PR. Thanks. |
larkee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the ITs against the Cloud Spanner emulator there were failures relating to result ordering. Spanner doesn't guarantee an order for its results unless specified by the ORDER BY clause. The emulator deliberately shuffles the results so users do not rely on the ordering without ORDER BY.
This PR updates a test to use ORDER BY to fix an emulator failure. However, since ORDER BY is not supported by partitioned queries, a set of the results is created for comparison in that test instead.