Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: testing for fgac-pg #902

Merged
merged 5 commits into from
Jun 6, 2023
Merged

feat: testing for fgac-pg #902

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0682e4
fgac-pg testing
asthamohta Feb 23, 2023
6449835
changes
asthamohta Jun 6, 2023
d18ec8e
Merge branch 'main' into fgac-pg
asthamohta Jun 6, 2023
a6ba822
changes
asthamohta Jun 6, 2023
4e5fb9a
Merge branch 'fgac-pg' of github.com:asthamohta/python-spanner into f…
asthamohta Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 30 additions & 22 deletions tests/system/test_database_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from google.type import expr_pb2
from . import _helpers
from . import _sample_data
from google.cloud.spanner_admin_database_v1 import DatabaseDialect


DBAPI_OPERATION_TIMEOUT = 240 # seconds
Expand Down Expand Up @@ -226,7 +227,6 @@ def test_iam_policy(
not_emulator,
shared_instance,
databases_to_delete,
not_postgres,
):
pool = spanner_v1.BurstyPool(labels={"testcase": "iam_policy"})
temp_db_id = _helpers.unique_id("iam_db", separator="_")
Expand Down Expand Up @@ -407,27 +407,31 @@ def test_update_ddl_w_default_leader_success(


def test_create_role_grant_access_success(
not_emulator,
shared_instance,
databases_to_delete,
not_postgres,
not_emulator, shared_instance, databases_to_delete, database_dialect
):
creator_role_parent = _helpers.unique_id("role_parent", separator="_")
creator_role_orphan = _helpers.unique_id("role_orphan", separator="_")

temp_db_id = _helpers.unique_id("dfl_ldrr_upd_ddl", separator="_")
temp_db = shared_instance.database(temp_db_id)
temp_db = shared_instance.database(temp_db_id, database_dialect=database_dialect)

create_op = temp_db.create()
databases_to_delete.append(temp_db)
create_op.result(DBAPI_OPERATION_TIMEOUT) # raises on failure / timeout.

# Create role and grant select permission on table contacts for parent role.
ddl_statements = _helpers.DDL_STATEMENTS + [
f"CREATE ROLE {creator_role_parent}",
f"CREATE ROLE {creator_role_orphan}",
f"GRANT SELECT ON TABLE contacts TO ROLE {creator_role_parent}",
]
if database_dialect == DatabaseDialect.GOOGLE_STANDARD_SQL:
ddl_statements = _helpers.DDL_STATEMENTS + [
f"CREATE ROLE {creator_role_parent}",
f"CREATE ROLE {creator_role_orphan}",
f"GRANT SELECT ON TABLE contacts TO ROLE {creator_role_parent}",
]
elif database_dialect == DatabaseDialect.POSTGRESQL:
ddl_statements = _helpers.DDL_STATEMENTS + [
f"CREATE ROLE {creator_role_parent}",
f"CREATE ROLE {creator_role_orphan}",
f"GRANT SELECT ON TABLE contacts TO {creator_role_parent}",
]

operation = temp_db.update_ddl(ddl_statements)
operation.result(DBAPI_OPERATION_TIMEOUT) # raises on failure / timeout.

Expand All @@ -445,27 +449,31 @@ def test_create_role_grant_access_success(
with temp_db.snapshot() as snapshot:
snapshot.execute_sql("SELECT * FROM contacts")

ddl_remove_roles = [
f"REVOKE SELECT ON TABLE contacts FROM ROLE {creator_role_parent}",
f"DROP ROLE {creator_role_parent}",
f"DROP ROLE {creator_role_orphan}",
]
if database_dialect == DatabaseDialect.GOOGLE_STANDARD_SQL:
ddl_remove_roles = [
f"REVOKE SELECT ON TABLE contacts FROM ROLE {creator_role_parent}",
f"DROP ROLE {creator_role_parent}",
f"DROP ROLE {creator_role_orphan}",
]
elif database_dialect == DatabaseDialect.POSTGRESQL:
ddl_remove_roles = [
f"REVOKE SELECT ON TABLE contacts FROM {creator_role_parent}",
f"DROP ROLE {creator_role_parent}",
f"DROP ROLE {creator_role_orphan}",
]
# Revoke permission and Delete roles.
operation = temp_db.update_ddl(ddl_remove_roles)
operation.result(DBAPI_OPERATION_TIMEOUT) # raises on failure / timeout.


def test_list_database_role_success(
not_emulator,
shared_instance,
databases_to_delete,
not_postgres,
not_emulator, shared_instance, databases_to_delete, database_dialect
):
creator_role_parent = _helpers.unique_id("role_parent", separator="_")
creator_role_orphan = _helpers.unique_id("role_orphan", separator="_")

temp_db_id = _helpers.unique_id("dfl_ldrr_upd_ddl", separator="_")
temp_db = shared_instance.database(temp_db_id)
temp_db = shared_instance.database(temp_db_id, database_dialect=database_dialect)

create_op = temp_db.create()
databases_to_delete.append(temp_db)
Expand Down