Storage: wait option for delete_blobs method

[VelizarVESSELINOV]

Environment details

latest

Steps to reproduce

blobs = [1000000 blobs]
slow_create_blobs(blobs)
delete_blobs(blobs)
slow_create_blobs(blobs)
assert count_blobs(blobs) = big_number

An unpredictable result depends on delete_blobs how fast it is versus the slow_create_blobs

[emar-kar]

@VelizarVESSELINOV Good day, sir. I was trying to reproduce the conditions of the described issue and that is why I would like to clarify some questions:

• slow_create_blobs(blobs) function is using upload_from_file or upload_from_string method? Is it possible to demonstrate it more specifically for the correct reproduction?
• Correct me if I'm wrong, but you are trying to create blobs with the same names as in the original list which was marked for deletion?

As I can see through the API structure when you are using the delete_blobs method it is just sending the delete request per each blob and it is not returning anything. So we need to find out will a suitable solution affects the internal server behavior. I'll appreciate your help in resolving this situation and improvement of the user experience, thanks.

[IlyaFaer]

@VelizarVESSELINOV, code snippet in this issue doesn't give much of info, but I think, you're using Bucket.delete_blobs() method. If so, it doesn't seem that "wait" option is needed. According to Storage docs, object deletion is strong consistent. That means, if you called objects.delete method and it returned empty result, than object is already deleted from Storage (see the method docs). In other words, you don't need a "wait" option, as delete_blobs() will return only when all specified blobs will be truly deleted. Thus, it's already waiting.

Closing this issue. Feel free to reopen, if you have any concerns/propositions.