fix(storage): fix system test and change scope for iam access token #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
System test throws 'Identity and Access Management (IAM) API has not been used in project before or it is disabled. ' error, so need (IAM) permission for this project. |
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
reviewed
Feb 11, 2020
tests/system.py
Outdated
| @@ -1066,7 +1067,7 @@ def test_create_signed_read_url_v4_w_access_token(self): | |||
| client = iam_credentials_v1.IAMCredentialsClient() | |||
| service_account_email = Config.CLIENT._credentials.service_account_email | |||
| name = client.service_account_path("-", service_account_email) | |||
| scope = ["https://www.googleapis.com/auth/devstorage.read_write"] | |||
| scope = ["https://www.googleapis.com/auth/cloud-platform"] | |||
There was a problem hiding this comment.
(we don't have to block merging on this as it is a test, but if this is needed it seems like a large scope for narrow use?)
There was a problem hiding this comment.
FWIW, I can confirm that both tests fail on master with a 403 without this patch.
Update: it fails even with the cloud-platform scope for me on master.
There was a problem hiding this comment.
Could you narrow the scope down to: https://www.googleapis.com/auth/iam
Documented at the bottom of the following document: https://cloud.google.com/iam/docs/reference/credentials/rest/v1/projects.serviceAccounts/signBlob
There was a problem hiding this comment.
To clarify, you can do join both:
scope = ['https://www.googleapis.com/auth/devstorage.read_write', 'https://www.googleapis.com/auth/iam']
crwilcox
approved these changes
Feb 11, 2020
frankyn
approved these changes
Feb 11, 2020
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…oogleapis#47) * fix(storage): change scope for iam access token * fix: narrow scope * fix: trailing commas * chore: blacken Co-authored-by: Christopher Wilcox <crwilcox@google.com>
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…oogleapis#47) * fix(storage): change scope for iam access token * fix: narrow scope * fix: trailing commas * chore: blacken Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46