Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove client side validations #868

Merged
merged 5 commits into from
Oct 6, 2022
Merged

fix: remove client side validations #868

merged 5 commits into from
Oct 6, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Sep 20, 2022 •
edited

Remove client-side validations and fall back to API errors per internal review doc

  • included: errors raised with unknown type/value
    • STORAGE_CLASSES
    • HMAC _SETTABLE_STATES
  • excluded: client-side validations that are reasonable and can avoid wasteful processing with API actions

Fixes #879
Fixes #880

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Sep 20, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 28, 2022
@cojenco cojenco marked this pull request as ready for review September 29, 2022 21:36
@cojenco cojenco requested review from a team as code owners September 29, 2022 21:36
andrewsg
andrewsg approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests as discussed

@cojenco cojenco merged commit 928ebbc into googleapis:main Oct 6, 2022
@release-please release-please bot mentioned this pull request Oct 6, 2022
Merged
@cojenco cojenco deleted the error_msg branch February 1, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove client side validation in HMAC Key Remove client side validation for storage class inputs
3 participants
@cojenco @andrewsg @yoshi-kokoro