Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update signing conformance test cases #1033

Merged
merged 4 commits into from
May 17, 2023

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented May 4, 2023

Update signing conformance test json file to match with https://github.com/googleapis/conformance-tests/blob/main/storage/v1/v4_signatures.json; Signature update required in relation to #378

Fixes #1010 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels May 4, 2023
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 10, 2023
@cojenco cojenco marked this pull request as ready for review May 10, 2023 21:51
@cojenco cojenco requested review from a team as code owners May 10, 2023 21:51
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label May 17, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2ad709a into googleapis:main May 17, 2023
13 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 17, 2023
@cojenco cojenco deleted the conformance-signing branch November 16, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: update signed url conformance test cases
2 participants