Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: create bucket with HNS enabled #1285

Merged
merged 3 commits into from
Jun 11, 2024
Merged

samples: create bucket with HNS enabled #1285

merged 3 commits into from
Jun 11, 2024

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Jun 5, 2024

Part of #1282

@cojenco cojenco requested review from a team as code owners June 5, 2024 20:46
@cojenco cojenco requested a review from rsamborski June 5, 2024 20:46
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jun 5, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Jun 5, 2024
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 6, 2024
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2024
@cojenco
Copy link
Contributor Author

cojenco commented Jun 6, 2024

pending internal cl/640967259 for py3.11 and py3.12 samples tests

@bajajneha27
Copy link

LGTM!
Will wait for the CI to pass.

@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 10, 2024
@cojenco cojenco requested a review from bajajneha27 June 10, 2024 20:18
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 11, 2024
@cojenco cojenco merged commit 693f195 into googleapis:main Jun 11, 2024
15 checks passed
@cojenco cojenco mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajajneha27 bajajneha27 bajajneha27 approved these changes

@rsamborski rsamborski Awaiting requested review from rsamborski rsamborski is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@vishwarajanand vishwarajanand

Labels
api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cojenco @bajajneha27 @vishwarajanand @yoshi-kokoro