Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: avoid depending on hash order #310

Merged
merged 1 commit into from Nov 12, 2020
Merged

tests: avoid depending on hash order #310

merged 1 commit into from Nov 12, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 11, 2020

Closes #309

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 11, 2020
@tseaver tseaver mentioned this pull request Nov 11, 2020
Merged
tswast
tswast approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm curious if this would still be flakey on versions of Python where key names are ordered by time of entry.

@tseaver tseaver merged commit 59d859f into master Nov 12, 2020
@tseaver tseaver deleted the 309-fix-hash-order-assumption branch November 12, 2020 21:59
@tseaver
Copy link
Contributor Author

tseaver commented Nov 12, 2020

@tswast The only flake I saw was on Python 3.5.

cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: avoid depending on hash order (googleapis#310)
552a5de 
Closes googleapis#309
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
tests: avoid depending on hash order (googleapis#310)
4304c3a 
Closes googleapis#309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@andrewsg andrewsg Awaiting requested review from andrewsg

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New test for 'Blob._do_multipart_upload' w/ metadata flakes
2 participants
@tseaver @tswast