Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

feat!: rename input to input_ in synthesize_speech method #99

Closed
wants to merge 26 commits into from
Closed

feat!: rename input to input_ in synthesize_speech method #99

wants to merge 26 commits into from

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Jan 6, 2021 •
edited by busunkim96

feat: add common resource path helpers

feat: expose client transport

feat: add from_service_account_info

fix: remove send/recv grpc limits

fix: add enums to types/__init__.py

docs: fix type references in docstrings

@yoshi-automation
changes without context
267ee84 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation
chore(py-library): update decrypt secrets file
1ffc4d2 
* chore(py-library): update decrypt secrets file

From https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/scripts/decrypt-secrets.sh

* docs: explain conditional

Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue Sep 8 11:35:59 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: d302f93d7f47e2852e585ac35ab2d15585717ec0
Source-Link: googleapis/synthtool@d302f93
@yoshi-automation
chore(python-library): use sphinx 1.5.5 for the docfx job
7fbd8da 
Originally tested at:
#89

This change will fix the missing docstring in the yaml files.

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Sep 10 04:12:14 2020 +0000
Source-Repo: googleapis/synthtool
Source-Sha: ffcee7952b74f647cbb3ef021d95422f10816fca
Source-Link: googleapis/synthtool@ffcee79
@yoshi-automation
build(python): use release-publish app for notifying GitHub of releas…
ce94d49 
* build(python): use release-publish app for notifying GitHub of release status

* fix: re-add pypi password

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Sep 16 08:46:42 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 257fda18168bedb76985024bd198ed1725485488
Source-Link: googleapis/synthtool@257fda1
@yoshi-automation
build(python): add secret manager in kokoro
84943f5 
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Sep 16 10:24:40 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: dba48bb9bc6959c232bec9150ac6313b608fe7bd
Source-Link: googleapis/synthtool@dba48bb
@yoshi-automation
chore(python): add sphinx doctest extension
43e6635 
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Mon Sep 21 13:09:57 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 27f4406999b1eee29e04b09b2423a8e4646c7e24
Source-Link: googleapis/synthtool@27f4406
@yoshi-automation
chore(python): remove note about editable installs
b9e8452 
`pip install -e .` is supported and is how we install the library for tests.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue Sep 22 12:06:12 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: a651c5fb763c69a921aecdd3e1d8dc51dbf20f8d
Source-Link: googleapis/synthtool@a651c5f
@yoshi-automation
chore(python): use BUILD_SPECIFIC_GCLOUD_PROJECT for samples
05bd615 
https://github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32

`BUILD_SPECIFIC_GCLOUD_PROJECT` is an alternate project used for sample tests that do poorly with concurrent runs on the same project.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Sep 30 13:06:03 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 9b0da5204ab90bcc36f8cd4e5689eff1a54cc3e4
Source-Link: googleapis/synthtool@9b0da52
@yoshi-automation
chore(python): use 'setup.py' to detect repo root
f90a13d 
Closes #792

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Fri Oct 9 15:06:33 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: e0ae456852bf22f38796deb79cff30b516fde244
Source-Link: googleapis/synthtool@e0ae456
@yoshi-automation
build(python): samples tests should pass if no samples exist
e79fb0b 
Source-Author: Daniel Sanche <d.sanche14@gmail.com>
Source-Date: Wed Oct 14 08:00:06 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 477764cc4ee6db346d3febef2bb1ea0abf27de52
Source-Link: googleapis/synthtool@477764c
@yoshi-automation
chore(python_library): change the docs bucket name
d28c662 
Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Fri Oct 16 09:58:05 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: da5c6050d13b4950c82666a81d8acd25157664ae
Source-Link: googleapis/synthtool@da5c605
@yoshi-automation
chore(docs): update code of conduct of synthtool and templates
64b5885 
Source-Author: Christopher Wilcox <crwilcox@google.com>
Source-Date: Thu Oct 22 14:22:01 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5f6ef0ec5501d33c4667885b37a7685a30d41a76
Source-Link: googleapis/synthtool@5f6ef0e
@yoshi-automation
docs: add proto-plus to intersphinx mapping
dba1c98 
Source-Author: Tim Swast <swast@google.com>
Source-Date: Tue Oct 27 12:01:14 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: ea52b8a0bd560f72f376efcf45197fb7c8869120
Source-Link: googleapis/synthtool@ea52b8a
@yoshi-automation
fix(python_library): fix external unit test dependencies
5a797b0 
I recently submitted https://github.com/googleapis/synthtool/pull/811/files, allowing external dependencies for unit tests. This fixes a small missing comma bug

Source-Author: Daniel Sanche <d.sanche14@gmail.com>
Source-Date: Thu Oct 29 16:58:01 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 6542bd723403513626f61642fc02ddca528409aa
Source-Link: googleapis/synthtool@6542bd7
@yoshi-automation
chore: add type hint check
96b3968 
Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Source-Date: Wed Nov 4 17:36:32 2020 -0800
Source-Repo: googleapis/synthtool
Source-Sha: 3d3e94c4e02370f307a9a200b0c743c3d8d19f29
Source-Link: googleapis/synthtool@3d3e94c
@yoshi-automation
chore: add blacken to template
2b46d04 
Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Source-Date: Thu Nov 5 15:22:03 2020 -0800
Source-Repo: googleapis/synthtool
Source-Sha: 1f1148d3c7a7a52f0c98077f976bd9b3c948ee2b
Source-Link: googleapis/synthtool@1f1148d
@yoshi-automation
fix: address lint issues
b360e10 
Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Source-Date: Thu Nov 12 11:30:49 2020 -0800
Source-Repo: googleapis/synthtool
Source-Sha: e89175cf074dccc4babb4eca66ae913696e47a71
Source-Link: googleapis/synthtool@e89175c
@yoshi-automation
docs(python): update intersphinx for grpc and auth
62fe3cf 
* docs(python): update intersphinx for grpc and auth

* use https for python intersphinx

Co-authored-by: Tim Swast <swast@google.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Nov 18 14:37:25 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 9a7d9fbb7045c34c9d3d22c1ff766eeae51f04c9
Source-Link: googleapis/synthtool@9a7d9fb
@yoshi-automation
docs(python): fix intersphinx link for google-auth
d04de9c 
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu Nov 19 10:16:05 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: a073c873f3928c561bdf87fdfbf1d081d1998984
Source-Link: googleapis/synthtool@a073c87
@yoshi-automation
chore: add config / docs for 'pre-commit' support
51f97d5 
Source-Author: Tres Seaver <tseaver@palladion.com>
Source-Date: Tue Dec 1 16:01:20 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: 32af6da519a6b042e3da62008e2a75e991efb6b4
Source-Link: googleapis/synthtool@32af6da
@yoshi-automation
chore(deps): update precommit hook pre-commit/pre-commit-hooks to v3.3.0
be553d5 
Source-Author: WhiteSource Renovate <bot@renovateapp.com>
Source-Date: Wed Dec 2 17:18:24 2020 +0100
Source-Repo: googleapis/synthtool
Source-Sha: 69629b64b83c6421d616be2b8e11795738ec8a6c
Source-Link: googleapis/synthtool@69629b6
@yoshi-automation
test(python): give filesystem paths to pytest-cov
62af003 
https://pytest-cov.readthedocs.io/en/latest/config.html

The pytest-cov docs seem to suggest a filesystem path is expected.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Dec 2 09:28:04 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: f94318521f63085b9ccb43d42af89f153fb39f15
Source-Link: googleapis/synthtool@f943185
@yoshi-automation
chore: update noxfile.py.j2
81d81dc 
* Update noxfile.py.j2

add changes from @glasnt to the template template to ensure that enforcing type hinting doesn't fail for repos with the sample noxfile (aka all samples repos)
See https://github.com/GoogleCloudPlatform/python-docs-samples/pull/4869/files for context

* fix typo

Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Source-Date: Thu Dec 3 13:44:30 2020 -0800
Source-Repo: googleapis/synthtool
Source-Sha: 18c5dbdb4ac8cf75d4d8174e7b4558f48e76f8a1
Source-Link: googleapis/synthtool@18c5dbd
@yoshi-automation
chore(deps): update precommit hook pre-commit/pre-commit-hooks to v3.4.0
a948fbf 
Co-authored-by: Tres Seaver <tseaver@palladion.com>

Source-Author: WhiteSource Renovate <bot@renovateapp.com>
Source-Date: Wed Dec 16 18:13:24 2020 +0100
Source-Repo: googleapis/synthtool
Source-Sha: aa255b15d52b6d8950cca48cfdf58f7d27a60c8a
Source-Link: googleapis/synthtool@aa255b1
@yoshi-automation
docs(python): document adding Python 3.9 support, dropping 3.5 support
b78551b 
Closes #787

Source-Author: Tres Seaver <tseaver@palladion.com>
Source-Date: Thu Dec 17 16:08:02 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: b670a77a454f415d247907908e8ee7943e06d718
Source-Link: googleapis/synthtool@b670a77
@yoshi-automation
chore: exclude .nox directories from linting
d44468a 
The samples tests create `.nox` directories
with all dependencies installed. These directories
should be excluded from linting.

I've tested this change locally, and it significantly
speeds up linting on my machine.

Source-Author: Tim Swast <swast@google.com>
Source-Date: Tue Dec 22 13:04:04 2020 -0600
Source-Repo: googleapis/synthtool
Source-Sha: 373861061648b5fe5e0ac4f8a38b32d639ee93e4
Source-Link: googleapis/synthtool@3738610
@yoshi-automation yoshi-automation requested review from leahecole and removed request for a team January 6, 2021 17:02
@product-auto-label product-auto-label bot added the api: texttospeech Issues related to the googleapis/python-texttospeech API. label Jan 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 6, 2021
@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. feat!: rename input to input_ in synthesize_speech method Feb 1, 2021
@busunkim96
Copy link
Contributor

Samples and system tests are impacted by change from input -> input_.

@leahecole
Copy link
Contributor

@busunkim96 is the best path to resolve this for someone on the team to edit this PR in autosynth-synthtool branch?

@busunkim96 busunkim96 mentioned this pull request Feb 25, 2021
Merged
@busunkim96
Copy link
Contributor

@leahecole In the spirit of minimizing breaking changes I've opened googleapis/gapic-generator-python#788 to see if we can revert the change. Please disregard this PR for now. :)

@busunkim96 busunkim96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 25, 2021
gcf-merge-on-green bot pushed a commit to googleapis/gapic-generator-python that referenced this pull request Feb 26, 2021
@busunkim96
fix: exclude 'input' from reserved names list (#788)
da2ff71 
The motivation for this is to prevent a breaking change in a library that has already been made GA: texttospeech googleapis/python-texttospeech#99. The TTS protos have a field named [`input`](https://github.com/googleapis/googleapis/blob/eabe7c0fde64b1451df6ea171b2009238b0df07c/google/cloud/texttospeech/v1/cloud_tts.proto#L134-L143).

Dialogflow CX beta appears to also have a field named `input`, but those changes have not yet been published and it is a pre-GA API.

https://github.com/search?l=Python&p=1&q=org%3Agoogleapis+input_&type=Code
@busunkim96
Copy link
Contributor

Change in gapic-generator-python to undo the breaking change has been merged, closing this PR to get a new one.

@busunkim96 busunkim96 closed this Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@telpirion telpirion telpirion approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

@sirtorry sirtorry Awaiting requested review from sirtorry

@leahecole leahecole Awaiting requested review from leahecole

Assignees
No one assigned
Labels
api: texttospeech Issues related to the googleapis/python-texttospeech API. cla: yes This human has signed the Contributor License Agreement. context: partial do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoshi-automation @busunkim96 @leahecole @telpirion