fix: linked-versions + includeComponentInTag=false should work

googleapis · Nov 14, 2022 · 60dcc6a · 60dcc6a
1 parent 7ebb59e
commit 60dcc6a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/docs/manifest-releaser.md b/docs/manifest-releaser.md
@@ -517,7 +517,7 @@ Example:
     },
     {
       "type": "linked-versions",
-      "group-name": "my group",
+      "groupName": "my group",
       "components": [
         "pkgA", "pkgB"
       ]

diff --git a/src/manifest.ts b/src/manifest.ts
@@ -501,7 +501,15 @@ export class Manifest {
         continue;
       }
       const component = tagName.component || DEFAULT_COMPONENT_NAME;
-      const path = pathsByComponent[component];
+      let path = pathsByComponent[component];
+      if (!path) {
+        for (const p in this.repositoryConfig) {
+          if (!this.repositoryConfig[p].includeComponentInTag) {
+            path = p;
+            break;
+          }
+        }
+      }
       if (!path) {
         this.logger.warn(
           `Found release tag with component '${component}', but not configured in manifest`

diff --git a/src/strategies/base.ts b/src/strategies/base.ts
@@ -155,9 +155,6 @@ export abstract class BaseStrategy implements Strategy {
    * @returns {string}
    */
   async getComponent(): Promise<string | undefined> {
-    if (!this.includeComponentInTag) {
-      return '';
-    }
     return this.component || (await this.getDefaultComponent());
   }