chore: review comments

googleapis · Nov 3, 2022 · 8e0de8c · 8e0de8c
1 parent 21ed0e1
commit 8e0de8c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/plugins/node-workspace.ts b/src/plugins/node-workspace.ts
@@ -346,7 +346,7 @@ export class NodeWorkspace extends WorkspacePlugin<Package> {
 
   private detectRangePrefix(version: string): string {
     return (
-      ['^', '~', '>', '<', '<=', '>='].find(supportedRangePrefix =>
+      Object.values(SUPPORTED_RANGE_PREFIXES).find(supportedRangePrefix =>
         version.startsWith(supportedRangePrefix)
       ) || ''
     );
@@ -361,6 +361,15 @@ export class NodeWorkspace extends WorkspacePlugin<Package> {
   }
 }
 
+enum SUPPORTED_RANGE_PREFIXES {
+  CARET = '^',
+  TILDE = '~',
+  GREATER_THAN = '>',
+  LESS_THAN = '<',
+  EQUAL_OR_GREATER_THAN = '>=',
+  EQUAL_OR_LESS_THAN = '<=',
+}
+
 function getChangelogDepsNotes(original: Package, updated: Package): string {
   let depUpdateNotes = '';
   type DT =

diff --git a/test/plugins/node-workspace.ts b/test/plugins/node-workspace.ts
@@ -172,11 +172,14 @@ describe('NodeWorkspace plugin', () => {
       );
       expect(nodeCandidate).to.not.be.undefined;
       const updates = nodeCandidate!.pullRequest.updates;
-      assertHasUpdate(updates, 'plugin1/package.json');
       assertHasUpdate(updates, 'node1/package.json');
 
-      expect(updates[1].updater).instanceof(RawContent);
-      const updater = updates[1].updater as RawContent;
+      const update = assertHasUpdate(
+        updates,
+        'plugin1/package.json',
+        RawContent
+      );
+      const updater = update.updater as RawContent;
       snapshot(updater.rawContent);
     });
     it('combines node packages', async () => {