Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-please: google-api-go-client failing with error " TypeError: Cannot read property 'repository' of undefined at GitHub.pullRequestsGraphQL " #1376

Closed
bcoe opened this issue Apr 11, 2022 · 1 comment · Fixed by #1377 or #1380
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bcoe
Copy link
Contributor

bcoe commented Apr 11, 2022

We are seeing failures in the releasea-please logs for google-api-go-client, with the error:

Screenshot 2022-04-11 6 19 04 PM

@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Apr 11, 2022
@chingor13
Copy link
Contributor

The GraphQL query is returning a 502 which is silently retried once and if it fails, it's silently returning.

@chingor13 chingor13 transferred this issue from googleapis/repo-automation-bots Apr 13, 2022
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 13, 2022
Fixes #1376

chore: add trace logging for when we hit 502s from the GraphQL API
fix: don't crash when pull request iterator GraphQL returns no response
fix: GraphQL retry now uses exponential backoff
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 13, 2022
🤖 I have created a release *beep* *boop*
---


### [13.10.1](v13.10.0...v13.10.1) (2022-04-13)


### Bug Fixes

* bump retries for pull request iterator from 1 to 3 ([#1377](#1377)) ([b2b7ff8](b2b7ff8)), closes [#1376](#1376)
* don't crash when pull request iterator GraphQL returns no response ([b2b7ff8](b2b7ff8))
* fixed maxResults check in tag and release iterators ([#1378](#1378)) ([6492a86](6492a86))
* GraphQL retry now uses exponential backoff ([b2b7ff8](b2b7ff8))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
2 participants