Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can I get manifest releaser to update node's devDependencies / peerDependencies fields too? #1943

Closed
TimothyJones opened this issue May 3, 2023 · 5 comments · Fixed by #2094
Closed

Can I get manifest releaser to update node's devDependencies / peerDependencies fields too? #1943

TimothyJones opened this issue May 3, 2023 · 5 comments · Fixed by #2094
Assignees
@chingor13
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@TimothyJones
Copy link
Contributor

What I am trying to do

I have a node monorepo managed with lerna, and I'm using release-please manifest. Inside the monorepo, I have some linked packages that compile with jsii. These need to link to each other with peerDependencies and devDependencies, instead of dependencies.

However, when the manifest releaser bumps the package numbers for linked packages, it only modifies the versions from dependencies. This means the release PR fails the build.

Is there a way I can get manifest-releaser with release-type: node to also update linked packages in devDependencies and peerDpendencies?

What code I've already tried

Extensively searched the documentation

Any error messages you're getting

Error messages on build because the versions that are included are not correct (not errors from release-please).
@TimothyJones TimothyJones added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels May 3, 2023
@TimothyJones
Copy link
Contributor Author

Apologies, it appears to update devDependencies - but not peerDependencies.

@TimothyJones
Copy link
Contributor Author

Perhaps this is actually a bug report? I haven't read the code too closely, but it looks like maybe peerDependencies should be in this list?

@TimothyJones
Copy link
Contributor Author

Anything I can do to help investigate this one?

@weaintplastic
Copy link

I'd also be interested in a solution to this.

@TimothyJones TimothyJones mentioned this issue Jun 13, 2023
Open
TimothyJones added a commit to TimothyJones/release-please that referenced this issue Oct 11, 2023
@TimothyJones
fix: Node workspace plugin now updates peer dependencies. Fixes googl…
955f3bf 
…eapis#1943
@TimothyJones TimothyJones mentioned this issue Oct 11, 2023
Merged
4 tasks
@TimothyJones
Copy link
Contributor Author

I raised a PR with a fix for this.

chingor13 added a commit that referenced this issue Dec 11, 2023
@TimothyJones @chingor13
fix(node-workspace): Add update-peer-dependencies option that also up…
c84414a 
…dates peer dependencies (#2094)

* fix: Node workspace plugin now updates peer dependencies. Fixes #1943

* test: Remove obsolete snapshot

* feat: Add update-peer-dependencies option to the node-workspace plugin

* chore: Remove unused snapshot

* test: Correct test for peerDependencies option

Fixes #1943

---------

Co-authored-by: Jeff Ching <chingor@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
3 participants
@chingor13 @TimothyJones @weaintplastic