feat: allow octokit to be dependency injected #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chingor13
reviewed
Aug 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 77.27% 77.65% +0.38%
==========================================
Files 21 21
Lines 2517 2547 +30
Branches 188 190 +2
==========================================
+ Hits 1945 1978 +33
+ Misses 559 557 -2
+ Partials 13 12 -1
Continue to review full report at Codecov.
|
chingor13
approved these changes
Aug 17, 2019
| @@ -79,30 +86,76 @@ interface GitHubPR { | |||
|
|
|||
| export class GitHub { | |||
| octokit: Octokit; | |||
| request: Function; | |||
There was a problem hiding this comment.
Question: what's the default visibility for these variables?
chingor13
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.