-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow octokit to be dependency injected #229
Conversation
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 77.27% 77.65% +0.38%
==========================================
Files 21 21
Lines 2517 2547 +30
Branches 188 190 +2
==========================================
+ Hits 1945 1978 +33
+ Misses 559 557 -2
+ Partials 13 12 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits. The refactoring could be done in another PR.
@@ -79,30 +86,76 @@ interface GitHubPR { | |||
|
|||
export class GitHub { | |||
octokit: Octokit; | |||
request: Function; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: what's the default visibility for these variables?
No description provided.