Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for releasing from non-master branches for legacy support #428

Closed
feywind opened this issue May 7, 2020 · 1 comment
Closed

Add support for releasing from non-master branches for legacy support #428

feywind opened this issue May 7, 2020 · 1 comment
Assignees
@chingor13 @feywind
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@feywind
Copy link
Contributor

feywind commented May 7, 2020

The intent here is to add the follow capabilities to release-please and any related bots (though this issue is only about release-please).

  • Projects can have a branch besides master that is designated as a release branch.
  • When PRs are merged into those branches, release-please will notice and make a release PR just like it does with master.
    • Those PRs will correctly find the next appropriate semver within the branch, not master.
  • When a maintainer merges the release PR, the regular machinery will push it along its way to a release in the relevant package manager.

The primary alternatives are:

  • Don't release from branches; this is becoming increasingly unpalatable because of discussions about the possibility of supporting non-latest versions, as well as the need to e.g. backport fixes to a stable branch until master is ready to release for whatever reason.
  • Manually handle the release process; having done this once, it is incredibly gross and error-prone. It also requires access to some potentially sensitive docs.

Context:

The motivating factor here is that the nodejs-pubsub library (@google-cloud/pubsub) has merged updates to master that are pointed at a 2.0 release; however, that 2.0 release requires a breaking TypeScript update, as well as breaking Node 8 support. The Node 8 deprecation has been held up for a while now due to various factors, so I have had the need to port important changes into what is currently the latest branch, and keep it releasing.

Note:

I've already completed a fair amount of the work here, I'm just working on getting it cleaned up and tested.
@feywind feywind self-assigned this May 7, 2020
@feywind feywind added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 7, 2020
@feywind feywind mentioned this issue May 7, 2020
Merged
jbottigliero added a commit to jbottigliero/release-please that referenced this issue Sep 29, 2020
@jbottigliero
fix: Source 'defaultBranch' from instance for getFileContents instead…
f0753e0 
… of argument.

Ensures the `github-release` command will source the default branch from the repository (currently not an option passed to the instance)

This seems related to googleapis#428
@jbottigliero jbottigliero mentioned this issue Sep 29, 2020
Merged
@feywind feywind mentioned this issue Oct 8, 2020
Merged
@feywind
Copy link
Contributor Author

feywind commented Oct 8, 2020

Linking this PR also. #429

@feywind feywind mentioned this issue Oct 9, 2020
Merged
@chingor13 chingor13 self-assigned this Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

@feywind feywind

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chingor13 @feywind