Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply multiple file updates in a single commit #469

Closed
socsieng opened this issue Jun 14, 2020 · 1 comment
Closed

Apply multiple file updates in a single commit #469

socsieng opened this issue Jun 14, 2020 · 1 comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@socsieng
Copy link
Contributor

socsieng commented Jun 14, 2020

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.

Each file that is updated by release-please has it's own commit. This is presumably because it is using the Contents API.

For example, the Contents API generates a git commit for each addition or change and uses the current time as the timestamp.

When one or two files are updated, this isn't as much of an issue, however, this is less than ideal once more files are updated (e.g. the addition of package-lock.json with #464).

Describe the solution you'd like

Ideally, all the updates related to the version number bump would be applied in a single commit. It looks like this could technically be achieved by using the Commits API.

Using the Commits API looks more complicated than the Contents API so I can understand if you don't think the increase in complexity is unjustified.

Describe alternatives you've considered

The alternative is to continue with individual commits and remember to merge the release pull request with the squash and merge option.

Additional context

Example of commits with three changes
Example of commits with three changes

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 15, 2020
@danoscarmike danoscarmike added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jun 16, 2020
@chingor13
Copy link
Contributor

This was completed in #536 and released in v6.0.0. We now use the code-suggester library to create the commit/pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants