Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code-suggester)!: move to code-suggester for PR management #536

Merged
merged 4 commits into from
Sep 4, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Sep 2, 2020

integrate release-please with code-suggester, benefits:

  1. the release PR comes in as a single commit (allowing us to stop adding [skip ci]).
  2. it seems as though this stops the behavior of PRs opening and closing as they're updated.

Depends on: googleapis/code-suggester#95

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2020
@bcoe bcoe changed the title feat!(code-suggester): move to code-suggester for PR management feat(code-suggester)!: move to code-suggester for PR management Sep 2, 2020
@chingor13
Copy link
Contributor

This looks nice!

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with annoying nits

src/github.ts Outdated Show resolved Hide resolved
src/github.ts Outdated Show resolved Hide resolved
src/github.ts Show resolved Hide resolved
src/github.ts Show resolved Hide resolved
src/github.ts Outdated Show resolved Hide resolved
@bcoe bcoe marked this pull request as ready for review September 4, 2020 01:55
@bcoe bcoe requested a review from a team as a code owner September 4, 2020 01:55
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #536 into master will increase coverage by 0.56%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   81.69%   82.25%   +0.56%     
==========================================
  Files          42       42              
  Lines        4993     4819     -174     
  Branches      407      414       +7     
==========================================
- Hits         4079     3964     -115     
+ Misses        913      854      -59     
  Partials        1        1              
Impacted Files Coverage Δ
src/github-release.ts 93.16% <ø> (-0.05%) ⬇️
src/releasers/java-bom.ts 93.70% <ø> (-0.10%) ⬇️
src/releasers/java-yoshi.ts 87.85% <ø> (-0.26%) ⬇️
src/releasers/simple.ts 92.70% <ø> (-0.08%) ⬇️
src/updaters/changelog.ts 100.00% <ø> (ø)
src/updaters/java/google-utils.ts 100.00% <ø> (ø)
src/updaters/java/java_update.ts 96.25% <ø> (-0.10%) ⬇️
src/updaters/package-json.ts 100.00% <ø> (ø)
src/updaters/php-client-version.ts 88.37% <ø> (-0.52%) ⬇️
src/updaters/php-manifest.ts 88.88% <ø> (-0.31%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c5e3d...d99a4d5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants