Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort commits from graphql output by descending commit date so we get fresh results #585

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

feywind
Copy link
Contributor

@feywind feywind commented Oct 8, 2020

Fix for a bug found in the work for #428

@feywind feywind requested a review from a team as a code owner October 8, 2020 22:23
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2020
@feywind feywind requested a review from bcoe October 8, 2020 22:23
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #585 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
- Coverage   81.03%   80.94%   -0.09%     
==========================================
  Files          85       85              
  Lines        9995     9999       +4     
  Branches      711      810      +99     
==========================================
- Hits         8099     8094       -5     
- Misses       1884     1893       +9     
  Partials       12       12              
Impacted Files Coverage Δ
src/github.ts 80.99% <100.00%> (+0.04%) ⬆️
src/releasers/java/bump_type.ts 76.31% <0.00%> (-2.64%) ⬇️
...ase/release-please/src/releasers/java/bump_type.ts 76.31% <0.00%> (-2.64%) ⬇️
D:/a/release-please/release-please/src/github.ts 74.94% <0.00%> (-1.65%) ⬇️
src/release-pr-factory.ts 81.96% <0.00%> (-1.64%) ⬇️
...-please/release-please/src/conventional-commits.ts 95.12% <0.00%> (-1.22%) ⬇️
src/releasers/java/version.ts 94.68% <0.00%> (-1.07%) ⬇️
.../a/release-please/release-please/src/release-pr.ts 86.70% <0.00%> (-0.95%) ⬇️
...se-please/release-please/src/graphql-to-commits.ts 86.25% <0.00%> (-0.95%) ⬇️
...elease-please/release-please/src/releasers/node.ts 89.85% <0.00%> (-0.73%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408b380...2c68a0a. Read the comment docs.

@bcoe bcoe merged commit 05897e7 into googleapis:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants