Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java file version bump not working on non default branches #968

Closed
kolea2 opened this issue Jul 14, 2021 · 2 comments
Closed

Java file version bump not working on non default branches #968

kolea2 opened this issue Jul 14, 2021 · 2 comments
Assignees
@chingor13
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kolea2
Copy link

kolea2 commented Jul 14, 2021 •
edited

We have am embedded java file that release please increments the version on for each release. It seems to work fine on the default branch:
https://github.com/googleapis/java-bigtable/pull/893/files#diff-872c3c6b3fd52460b8f485ffa56921b841e02c4a563598aad8ad1be186292625R23

But not on a branch release:
googleapis/java-bigtable#831 (I had to push the version number myself)
@kolea2
Copy link
Author

kolea2 commented Jul 14, 2021

CC @igorbernstein2

@tmatsuo tmatsuo added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 14, 2021
@chingor13
Copy link
Contributor

extraFiles option is a per-branch configuration - in your .github/release-please.yml, extraFiles are configured at the root (for the default branch), but not on the 1.22.0-sp branch

@chingor13 chingor13 mentioned this issue Jul 14, 2021
Merged
@kolea2 kolea2 mentioned this issue Jul 14, 2021
Merged
gcf-merge-on-green bot pushed a commit to googleapis/java-bigtable-hbase that referenced this issue Jul 14, 2021
@kolea2
fix: add extraFiles to 1x branch (#3160)
f6c7824 
googleapis/release-please#968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chingor13 @tmatsuo @kolea2