Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 13.0.0 #1105

Merged
merged 1 commit into from
Dec 22, 2021
Merged

chore: release 13.0.0 #1105

merged 1 commit into from
Dec 22, 2021

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Nov 23, 2021

🤖 I have created a release *beep* *boop*

13.0.0 (2021-12-22)

⚠ BREAKING CHANGES

  • releasers are now "strategies", more logic moved into base classes
  • Node 12 is now required
  • manifest is now main entrypoint for release please, and logic is shared between mono-repo/split-repo flow
  • versioning straregy now handled by VersionStrategies rather than regexes
  • merge Manifest and standard PR paths (refactor!: merge Manifest and standard PR paths #1104)

Features

  • add includeComponentInTag option for strategies and hook up to --monorepo-tags (#1119) (bf9aacd)
  • add ability to override merged commit message (#1161) (c568b57), closes #967
  • add GitHub changelog notes generator (#1120) (1470661)
  • enable specifying changelog section headings in the CLI (#1162) (aaa8342), closes #511
  • go: add support for bumping a Go version file (#1112) (8f6e52b)
  • reimplement custom pull request title (#1122) (2f3e84c)
  • reimplement Java 1.0.0 special version bumping (#1126) (28bc76b)
  • return path along with created release (#1114) (81fc0f4)

Bug Fixes

  • add back version/major/minor/patch (#1118) (4b6ae50)
  • allow setting release-type at root of manifest config (#1159) (fc73b6d)
  • backfill commit files (#1110) (173ce70)
  • backfill latest release with version found in manifest (#1131) (94859a0)
  • cli: pass pull-request-title-pattern (#1128) (28d7727)
  • combined manifest PR should include labels (#1137) (d8bb7ca)
  • fallback to look at releases when looking for latest release (#1146) (76ed1a7)
  • fallback to look at tags when looking for latest release (#1160) (e06c6ba)
  • GitHub#findFilesByExtension should treat prefix as a directory (#1165) (b48ec5b)
  • github: correctly return maxResults releases (#1134) (25f6811)
  • make PullRequest, ReleasePullRequest, Version fields readonly (#1150) (9659c1c)
  • Manifest.fromConfig can find latest release version without component (#1123) (0aeb67b)
  • merge manifest release PRs unless separatePullRequests is configured (#1129) (328009d)
  • only backfill files if requested (#1151) (ae007fe)
  • reimplement draft releases (#1111) (6f38b4a)
  • rust: Don't update dev-dependencies lacking a version key (#1095) (#1152) (56f37d9), closes #1094
  • switch branch delimiter to -- (#1127) (26442f1)

Code Refactoring

  • manifest is now main entrypoint for release please, and logic is shared between mono-repo/split-repo flow (fd8f9fc)
  • merge Manifest and standard PR paths (#1104) (fd8f9fc)
  • Node 12 is now required (fd8f9fc)
  • releasers are now "strategies", more logic moved into base classes (fd8f9fc)
  • versioning straregy now handled by VersionStrategies rather than regexes (fd8f9fc)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested a review from a team November 23, 2021 20:16
@release-please release-please bot requested a review from a team as a code owner November 23, 2021 20:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 23, 2021
@bcoe bcoe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 23, 2021
@bcoe
Copy link
Contributor

bcoe commented Nov 23, 2021

This is a major refactor, and we'd like to test in a bunch of real world repos before we roll out to everyone.

@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2021
@kalosisz
Copy link
Contributor

kalosisz commented Nov 23, 2021

@bcoe this refactor would remove the possibility to create draft releases, but it brings about draft PRs. was this intentional?

/**
* Open a pull request
*
* @param {ReleasePullRequest} releasePullRequest Pull request data to update
* @param {string} targetBranch The base branch of the pull request
* @param {GitHubPR} options The pull request options
* @throws {GitHubAPIError} on an API error
*/
async createReleasePullRequest(
releasePullRequest: ReleasePullRequest,
targetBranch: string,
options?: {
signoffUser?: string;
fork?: boolean;
}
): Promise<PullRequest> {
let message = releasePullRequest.title.toString();
if (options?.signoffUser) {
message = signoffCommitMessage(message, options.signoffUser);
}
return await this.createPullRequest(
{
headBranchName: releasePullRequest.headRefName,
baseBranchName: targetBranch,
number: -1,
title: releasePullRequest.title.toString(),
body: releasePullRequest.body.toString().slice(0, MAX_ISSUE_BODY_SIZE),
labels: releasePullRequest.labels,
files: [],
},
targetBranch,
message,
releasePullRequest.updates,
{
fork: options?.fork,
draft: releasePullRequest.draft,
}
);
}

release-please/src/github.ts

Lines 1139 to 1176 in fd8f9fc

/**
* Create a GitHub release
*
* @param {Release} release Release parameters
* @param {boolean} draft Whether or not to create the release as a draft
* @throws {DuplicateReleaseError} if the release tag already exists
* @throws {GitHubAPIError} on other API errors
*/
createRelease = wrapAsync(
async (release: Release): Promise<GitHubRelease> => {
const resp = await this.octokit.repos.createRelease({
owner: this.repository.owner,
repo: this.repository.repo,
tag_name: release.tag.toString(),
body: release.notes,
sha: release.sha,
});
return {
name: resp.data.name || undefined,
tagName: resp.data.tag_name,
sha: resp.data.target_commitish,
notes: resp.data.body_text,
url: resp.data.html_url,
};
},
e => {
if (e instanceof RequestError) {
if (
e.status === 422 &&
GitHubAPIError.parseErrors(e).some(error => {
return error.code === 'already_exists';
})
) {
throw new DuplicateReleaseError(e, 'tagName');
}
}
}
);

@chingor13
Copy link
Contributor

@bcoe this refactor would remove the possibility to create draft releases, but it brings about draft PRs. was this intentional?

This is not intentional, we will bring it back.

@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 24, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 26, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 26, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 22, 2021
@chingor13 chingor13 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 22, 2021
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit b97ba09 into main Dec 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the release-v13.0.0 branch December 22, 2021 22:40
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 22, 2021
@release-please
Copy link
Contributor Author

@release-tool-publish-reporter

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: published cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants