New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adding local testing steps to contributing guide #1743
Conversation
Write down that. In another project (owlbot bootstrapper) it is "npm compile && npm link" |
@ddixit14 That 2nd part, "node build/src .." command, seems correct. But the 1st part, "release-please release-pr .." command, does not use the some new code without the command is rebuilt. |
I don't understand what you're trying to say. |
|
||
``` | ||
release-please release-pr \ | ||
node build/src/bin/release-please.js release-pr \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's clear. Thank you.
@bcoe Can you merge this? |
|
||
``` | ||
node build/src/bin/release-please.js release-pr \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build/src/bin/release-please.js? Not typescript?
Hi team, just adding some stuff to the guide that maybe useful for contributors.
@suztomo Opened this new PR because I was unable to edit the last one, looks like I messed up with the head of that branch while working on the versioning strategy. Also, there are no steps to generate release-please command afaik. It is included in the node build command. Multi-line command is fixed.
@chingor13 can you please approve this one?