New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adding new versioning strategies #1744
Conversation
Tested it locally on a |
@chingor13 Need some insights to write new tests/make the tests pass. |
For the new strategy, follow the test cases already written for "always-bump-patch". (I hope the tests are there). Found:
test/cli.js is untouched. Flaky tests? Needs help from Jeff. |
We use a snapshot of the |
… into versioning-strat
@ddixit14 Do you plan to add a test case in versioning-strategies/java.ts ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please add unit tests for the new versioning strategies even though they seem trivial.
Otherwise, LGTM.
import {AlwaysBumpMinor} from '../../src/versioning-strategies/always-bump-minor'; | ||
import {Version} from '../../src/version'; | ||
|
||
describe('MinorVersioningStrategy', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nit, this should be AlwaysBumpMinorStrategy
, my bad because I copy pasted this.
…rategies in schema (#5262) Adding "always-bump-minor" and "always-bump-major" to the allowed values for versioning. Reference PR: googleapis/release-please#1744 Co-authored-by: Jeff Ching <chingor@google.com>
This PR adds two new versioning strategies: