Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ruby): gemfile.lock should not update when gem name is empty #1805

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix(ruby): gemfile.lock should not update when gem name is empty #1805

merged 1 commit into from
Jan 17, 2023

Conversation

andrewthauer
Copy link
Contributor

@andrewthauer andrewthauer commented Jan 17, 2023 •
edited

PR #1790 introduced support to update Gemfile.lock files. However this introduced an issue that updates random gem versions when the package-name (gemName) is not provided (which is optional). This fix ensures the gemName is valid before attempting to update the Gemfile.lock file.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes issue introduced in PR #1790

@andrewthauer
fix(ruby): gemfile.lock should not update when gem name is empty
d6c1cdd 
PR googleapis#1790 introduced support to update Gemfile.lock files. However this
introduced an issue that updates random gem versions when the
`package-name` (gemName) is not provided (which is optional). This fix
ensures the gemName is valid before attempting to update the
Gemfile.lock file.
@andrewthauer andrewthauer requested a review from a team as a code owner January 17, 2023 14:35
@andrewthauer andrewthauer requested a review from a team January 17, 2023 14:35
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 17, 2023
@chingor13 chingor13 merged commit b54d499 into googleapis:main Jan 17, 2023
@release-please release-please bot mentioned this pull request Jan 17, 2023
Merged
@andrewthauer andrewthauer deleted the fix-ruby-gemfile-lock branch January 17, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewthauer @chingor13